Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python installation in expo publisher dockerfile #1570

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix python installation in expo publisher dockerfile #1570

merged 1 commit into from
Nov 8, 2021

Conversation

imjoehaines
Copy link
Contributor

Goal

There is no "python" package in Alpine linux; it has "python2" and "python3" instead

I'm not sure how this worked previously, but it has started complaining that the "python" package doesn't exist: https://buildkite.com/bugsnag/bugsnag-js-expo/builds/3511#f003482c-cf37-4312-8218-3ce0bad1ab66/191-222

All of our other dockerfiles that install Python use "python3"

@imjoehaines imjoehaines requested a review from a team November 8, 2021 09:46
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.54 kB 12.79 kB
After 41.54 kB 12.79 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 272505b

@djskinner
Copy link
Contributor

See https://alpinelinux.org/posts/Alpine-3.12.0-released.html

There is no longer a python package providing python2. You need to explicitly install python2 or python3. Additionally, as part of the ongoing work to remove python2, many python2 modules have been removed.

@imjoehaines imjoehaines merged commit 79d0b22 into next Nov 8, 2021
@imjoehaines imjoehaines deleted the fix-expo-publisher branch November 8, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjoehaines @djskinner